Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baseline #185

Closed
wants to merge 184 commits into from
Closed

Baseline #185

wants to merge 184 commits into from

Conversation

0xdewy
Copy link
Contributor

@0xdewy 0xdewy commented Nov 2, 2018

No description provided.

0xdewy and others added 30 commits October 26, 2018 12:33
@0xdewy
added more code examples in readme"
77ab958
@PeterMPhillips
Universal events progress
5c17b6e
@PeterMPhillips
Updated gitignore
5818b35
@bookmoons
Add TimedVote
5cb3b2d
@bookmoons
vote: Define Commitment
a9b8ce3
@PeterMPhillips
Events added
444066d
@PeterMPhillips
Merge baseline
34f18fe
@bookmoons
vote: Simplify type Commitment comments
f100ffa
@bookmoons
vote: Extend comment alignment
72443fc
@bookmoons
vote: Normalize comment placement
7d60fe3
@bookmoons
vote: Define commitments mapping
dacea8c
@bookmoons
vote: Add test fixture
e634cd8
@bookmoons
vote: Add separator to @param
d2cbfd2
@bookmoons
vote: Add missing semicolon
6d6253b
@bookmoons
vote: Make top test scope synchronous
b8b943e 
Async function seemingly unnecessary.
@bookmoons
vote: Move test preliminaries into hooks
c948a3f
@bookmoons
vote: Add #isCommitted
a7f8ad8
@bookmoons
vote: Name return values
1a48bf0
@bookmoons
vote: Correct fixture #_setCommitment
82efaa6
@bookmoons
vote: Add #onlyCommitted
43d8343
@bookmoons
vote: Simplify test helper names
0eed88a
@bookmoons
vote: Add #onlyUncommitted
a182a27
@bookmoons
vote: Use fresh contracts every test
520f90a
@bookmoons
vote: Use @dev for modifier documentation
5784899
@bookmoons
vote: Remove succeeds helper
89bf19a 
Unnecessary. A test with no assertions succeeds.
@0xdewy
Merge pull request #175 from PeterMPhillips/master
1cea287 
Events
@bookmoons
vote: Add #commit
83d3b4b
@bookmoons
vote: Add Commit event
607d228
@bookmoons
vote: Add missing semicolon in test
05d5cd1
@bookmoons
vote: Add #withdraw
269ed89
bookmoons and others added 27 commits October 31, 2018 22:24
@bookmoons
vote: Add title comment for Decline event
e027fd5
@bookmoons
vote: Correct #multiplierOf semantics description
d4e1038
@bookmoons
vote: Describe #commitmentOf behavior on no commitment
c317d8a
@0xdewy
Merge pull request #178 from PeterMPhillips/master
11d7e9f 
Integrated AssetManagerFunds, AssetGenerator and Events
@0xdewy
Merge pull request #180 from MyBitFoundation/baseline
660e374 
Updated AssetManagerFunds, customizeable crowdsale start-date, universal events implemeted
@0xdewy
Merge pull request #43 from MyBitFoundation/develop
affc6a9 
Develop
@0xdewy
setting up ethPM
03f67ed
@0xdewy
Merge pull request #181 from kyledewy/master
ec08451 
ethPM
@PeterMPhillips
Merge pull request #179 from bookmoons/bookmoons/timedvote
5771373 
Timed voting smart contract
@bookmoons
Add BurnableToken contract test fixture
807baad
@bookmoons
vote: Use BurnableToken fixture
712bc68
@bookmoons
Wrap BurnableToken transfer method in fixture
5ad6fc8
@bookmoons
Wrap BurnableToken transferFrom method in fixture
719fe5b
@bookmoons
Group BurnableTokenFixture members
2c1af78
@bookmoons
vote: Test transfer failure during #withdraw
c27d003
@bookmoons
Describe BurnableTokenFixture#_failNextTransfer
db66f54
@bookmoons
vote: Test transfer failure during #commit
5058ac9
@bookmoons
Rename *Fixture to *Stub
ccefe8f 
Fixture seems to describe the configuration of the environment
for a specific test case. Sinon uses the term stub to describe
a method that provides control over output. Stretching that a
little to describe a contract with stubbed methods.
@bookmoons
vote: Test ~time
45eaf0c
@0xdewy
Merge pull request #182 from bookmoons/bookmoons/timedvote-coverage
8ba1d6b 
Complete voting contract coverage
@0xdewy
removed all burn requirements"
a18cd02
@0xdewy
Merge pull request #183 from MyBitFoundation/baseline
3bfbf77 
Baseline
@0xdewy
Merge pull request #44 from MyBitFoundation/develop
776c79c 
Develop
@0xdewy
restrict non-upgradeable platforms from using remove and upgrade cont…
03ee079 
…racts
@0xdewy
Merge branch 'master' of https://github.com/kyledewy/MyBit-Network.tech
737a7c5
@0xdewy
updated upgrade restrictions in database
f62e076
@0xdewy
Merge pull request #184 from kyledewy/master
85c79c3 
Removed burn requirements. Fixed upgradeable/non-upgradeable restrictions.
@0xdewy 0xdewy closed this Nov 2, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 171

  • 217 of 220 (98.64%) changed or added relevant lines in 23 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+5.2%) to 79.859%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/crowdsale/CrowdsaleERC20.sol 5 6 83.33%
contracts/crowdsale/CrowdsaleGeneratorERC20.sol 7 8 87.5%
contracts/database/Events.sol 10 11 90.91%
Files with Coverage Reduction New Missed Lines %
contracts/crowdsale/CrowdsaleERC20.sol 1 79.79%
Totals Coverage Status
Change from base Build 145: 5.2%
Covered Lines: 930
Relevant Lines: 1133
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterMPhillips PeterMPhillips Awaiting requested review from PeterMPhillips

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0xdewy @coveralls @PeterMPhillips @bookmoons