Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging latest contracts and tests. #35

Merged
merged 101 commits into from
Jul 27, 2018
Merged

Merging latest contracts and tests. #35

merged 101 commits into from
Jul 27, 2018

Conversation

0xdewy
Copy link
Contributor

@0xdewy 0xdewy commented Jul 24, 2018

Here are the breaking changes:

Flow

  • The ETH/USD and MYB/USD prices must be set every 24hrs. Can be called at setDailyPrices(etherPrice, mybPrice(scaled up 10^3)

  • Users can burn their MYB access fee in a single transaction by calling approveAndCall(TokenBurnContract, amount, dataBytes). NOTE: Access expires after 365 days.

  • Can batch withdrawl income earned from several assets in a single transaction. (NEEDS TESTING) (Asset.sol)

Variables

  • assetOperator is now called assetManager (AssetManager.sol)

Functions

newAsset() no longer requires a manual assetID, but requires two additional parameters:

  • (BlockAtCreation, which is the block at which the staking agreement was made. If no staking agreement was made any number or 0 will work.
  • The IPFS hash of asset Title, Description, Location and images are stored. This is found in the event LogAssetFundingStarted(assetID, installerID, assetType, ipfsHash) (AssetCreation.sol)

Events

  • Moved assetID as the first parameter for all event logs and removed block.timestamps as their redundant.
  • Added assetID to LogRefund(_assetID, msg.sender, ownershipUnits); (FundingHub.sol)
  • The event called LogInvestmentPaid() is now called LogIncomeWithdrawl() (Asset.sol)

connorblockchain and others added 30 commits March 26, 2018 12:05
* feature: achievements react component

* refactor: removed unnecessary constructor

* refactor: updated to correct style class name

* refactor: standardising bem names

* refactor: flattened nested styles
… using a uint parameter in newAsset. This removes Oracle requirements for escrow
@0xdewy 0xdewy merged commit f39ed12 into MyBitFoundation:master Jul 27, 2018
0xdewy added a commit that referenced this pull request Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants