-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging latest contracts and tests. #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for all contracts to obtain 100%
…itDapp into solcCoverage
…itDapp into solcCoverage
* feature: achievements react component * refactor: removed unnecessary constructor * refactor: updated to correct style class name * refactor: standardising bem names * refactor: flattened nested styles
…into Feature/testnet-updates
… using a uint parameter in newAsset. This removes Oracle requirements for escrow
… bytecode and stakingbank payout
…oracle price update timeline
Feature/inner alpha
Added IPFS hash as newAsset() creation parameter for provable reference
Merging new staking, escrow and IPFS compatible contracts.
…indexes to only include ID's and addresses
…default port given by truffle
csmartinsfct
approved these changes
Jul 27, 2018
0xdewy
added a commit
that referenced
this pull request
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the breaking changes:
Flow
The ETH/USD and MYB/USD prices must be set every 24hrs. Can be called at
setDailyPrices(etherPrice, mybPrice(scaled up 10^3)
Users can burn their MYB access fee in a single transaction by calling
approveAndCall(TokenBurnContract, amount, dataBytes)
. NOTE: Access expires after 365 days.Can batch withdrawl income earned from several assets in a single transaction. (NEEDS TESTING) (Asset.sol)
Variables
Functions
newAsset() no longer requires a manual assetID, but requires two additional parameters:
LogAssetFundingStarted(assetID, installerID, assetType, ipfsHash)
(AssetCreation.sol)Events