Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBO-96 ORCID-Anbindung optimieren #284

Merged
merged 70 commits into from
Aug 28, 2023

Conversation

Possommi
Copy link
Collaborator

No description provided.

@Possommi Possommi force-pushed the issues/UBO-96-ORCID-Anbindung-optimieren branch 7 times, most recently from 5286ab0 to 059ddff Compare April 27, 2023 16:07
@Possommi Possommi force-pushed the issues/UBO-96-ORCID-Anbindung-optimieren branch 8 times, most recently from a61d513 to 42fb716 Compare May 10, 2023 12:15
@Possommi Possommi force-pushed the issues/UBO-96-ORCID-Anbindung-optimieren branch 2 times, most recently from b3bb038 to 6084faf Compare May 16, 2023 09:24
@kkrebs kkrebs force-pushed the issues/UBO-96-ORCID-Anbindung-optimieren branch from 83d1c35 to 14a6e60 Compare June 16, 2023 10:32
@Possommi Possommi marked this pull request as ready for review June 30, 2023 09:20
UBO-96 Added i18n key 'orcid.integration.unlink'

UBO-96 Added DozBibUserServlet

UBO-96 Code format web-fragment.xml

UBO-96 Placed orcid button inside <p>-element

UBO-96 Added Testing Servlet

UBO-96 Store updated UserAttributes

UBO-96 Check for guest user
Commented code to make ubo-common compile
UBO-96 Renamed mycore-orcid properties to their equivalent mycore-orcid2 properties
Possommi and others added 25 commits August 28, 2023 09:55
…ntegration.settings.alwaysUpdateWork, orcid.integration.settings.createDuplicateWork, orcid.integration.settings.recreateDeletedWork to messages_en.properties
…urns now the total of publications based on all connected orcids)
@Possommi Possommi force-pushed the issues/UBO-96-ORCID-Anbindung-optimieren branch from 6934a2b to 2e349cb Compare August 28, 2023 08:03
@kkrebs kkrebs merged commit eee7c80 into develop Aug 28, 2023
2 checks passed
@kkrebs kkrebs deleted the issues/UBO-96-ORCID-Anbindung-optimieren branch August 28, 2023 12:03
Possommi added a commit that referenced this pull request Sep 5, 2023
* UBO-96 Added button to unlink user account from ORCID

UBO-96 Added i18n key 'orcid.integration.unlink'

UBO-96 Added DozBibUserServlet

UBO-96 Code format web-fragment.xml

UBO-96 Placed orcid button inside <p>-element

UBO-96 Added Testing Servlet

UBO-96 Store updated UserAttributes

UBO-96 Check for guest user

* UBO-96 Added dependency to org.mycore:mycore-orcid2

* UBO-96 Removed dependency to org.mycore:mycore-orcid
Commented code to make ubo-common compile

* UBO-96 Set redirect url to $WebApplicationBaseURL/orcid

* UBO-96 Added ORCIDTools.js
UBO-96 Renamed mycore-orcid properties to their equivalent mycore-orcid2 properties

* UBO-96 Updated check for presence of orcid token

* UBO-96 Updated DozBibUserServlet to use mycore-orcid2 api

* UBO-96 Added method 'revoke' to ORCIDTools.js

* UBO-96 Added ubo-dialog.xsl

* UBO-96 Show confirm dialog when user trys to revoke orcid connection

* UBO-96 Read number of publications for user from orcid
UBO-96 Added DozBibORCIDUtils (WIP)

* UBO-96 Test for orcid_credential attribute rather than orcid_id

* UBO-96 Added public static boolean weAreTrustedParty() to DozBibORCIDUtils

* UBO-96 Renamed DozBibUserServlet to DozBibORCIDUserServlet and moved class to package /org/mycore/ubo/orcid/

* UBO-96 Migrated orcid list import

* UBO-96 Renamed property MCR.ORCID.LinkURL to MCR.ORCID2.LinkURL in mods-display.xsl

* UBO-96 Migrated mycore2orcid.js to mycore-orcid2

* UBO-96 Added simple notification dialog to ubo-dialog.xsl

* UBO-96 Fixed grammar

* UBO-96 Do not use slang as button label

* UBO-96 Changed upload to orcid button type

* UBO-96 Fixed orcid indicator title/tooltip

* UBO-96 Fixed link to orcid in user profile

* UBO-96 Reflect changes from /rsc to /api in mycore-orcic2 (WIP)

* UBO-96 Added orcid2 properties

* UBO-96 Deprecated ORCIDTools.js

* UBO-96 Use JWT and include /modules/orcid2/js/orcid-auth.js from mycore-orcid2

* UBO-96 Removed ORCIDTools.js

* UBO-96 Removed method loadScript()

* UBO-96 Reflect recent changes in mycore-orcid2

* UBO-96 Use POST http method for pushing a publication to ORCID

* UBO-96 Changed position of MCRORCIDWorkEventHandler

* UBO-96 Endpoint is splitted into update and create

* UBO-96 Allow user to activate automatic update of ORCID® profile

* UBO-96 Reflect sync status in orcid status headline

* UBO-96 Renamed user attribute to orcid_update_profile (name might change later)

* UBO-96 Changed some i18n values in messages_en.properties

* UBO-96 Fixed NPE and updated javadoc

* UBO-96 Remove TODO in MCRUserMatcherUtils

* UBO-96 Delete user attribute 'orcid_update_profile' when orcid auth is removed

* UBO-96 Added action parameter to DozBibORCIDUserServlet

* UBO-96 Do not die on invalid token

* UBO-96 Set propert MCR.ORCID2.WorkEventHandler.UpdateOnlyExisting = true

* UBO-96 Format

* UBO-96 Disable upload to orcid button once it was clicked

* UBO-96 Test for property MCR.ORCID2.Client.V3.APIMode

* UBO-96 Added include in html-layout.xsl to user-orcid.xsl

* UBO-96 public static String getFirstOrcidByCurrentUser() to DozBibORCIDUtils to enable linking to orcid

* UBO-96 Updated import of MCRORCIDWorkUtils to org.mycore.orcid2.v3.work.MCRORCIDWorkUtils

* UBO-96 Updated MCR.EventHandler.MCRObject.018A.Class

* UBO-96 Updated properties reflecting latest changes in mycore-orcid2

* UBO-96 Disabled update by user

* UBO-96 Show id of publication when logging to js console

* UBO-96 adopt to new orcid2 version

* UBO-96 update ORCIDWorkEventHandler to new version

* UBO-96 updated create-work path

* Improve orcid unlinking and allow to change user settings

* UBO-96 Added i18n orcid.integration.list to messages_en.properties

* UBO-96 Added i18n orcid.integration.settings.title to messages_en.properties

* UBO-96 Added i18n orcid.integration.settings.createFirstWork, orcid.integration.settings.alwaysUpdateWork, orcid.integration.settings.createDuplicateWork, orcid.integration.settings.recreateDeletedWork to messages_en.properties

* UBO-96 reformat message properties for better diff

* UBO-96 fix translation bug

* UBO-96 set editable user attributes, to prevent editing of orcid token

* UBO-96 Added public static int getNumWorks(String orcid) to DozBibORCIDUtils.java

* UBO-96 Added javadoc and altered public static int getNumWorks() (returns now the total of publications based on all connected orcids)

* UBO-96 Display orcid id in summary line

* UBO-96 Added public static boolean isConnected(String orcid) to DozBibORCIDUtils

* UBO-96 Removed public static boolean hasSyncEnabled() from DozBibORCIDUtils since it is obsolete

* UBO-96 Fixed javadoc in DozBibORCIDUserServlet

* UBO-96 update information text

---------

Co-authored-by: Kathleen Neumann <neumann@gbv.de>
Co-authored-by: Sebastian Hofmann <sebastian.hofmann@gbv.de>
kkrebs added a commit that referenced this pull request Jan 15, 2024
* develop:
  add facet support for peer reviewed
  DMS-301 add css class for JOP service images and fix layout
  revert UBO-269 FSU040THUL-1276 - need some clarification
  UBO-293 FSU040THUL-2186 Fixed heading generated by org.mycore.ubo.publication.PublicationEventHandler.getRealNameFromNameElement for local users to "family name, given name" (#344)
  UBO-292 Made org.mycore.ubo.matcher.MCRUserMatcherLDAP#getUserNameFromLDAPUser protected (#343)
  UBO-285 Added missing i18n ubo.interviewer.abbreviated
  UBO-289 Surround 'MCRORCIDSessionUtils.getCurrentUser()' with try/catch (#341)
  UBO-287 Use xsl:key to speed up transformation
  DMS-300 adds a better way to show authors without floating
  UBO-281 Do not rely on certain values of display index of a work. Improved code readability (#333)
  UBO-282 Include mycore2orcid.js inresponse.xsl (was accidentally remo… (#339)
  UBO-282 Include mycore2orcid.js only when user is not guest (#334)
  UBO-280 Fixed incorrect display of ; (#332)
  add type submit to editor buttons
  layout fix: prevent breaking in names
  add partOf, connectionID and origin facets to default configuration
  UBO-275 Do not reuse stream
  UBO-277 Removed @min="4" from repeat element
  UBO-274 Fixed ArrayIndexOutBoundException when language code cannot be resolved
  layout finetuning for popover header close button
  do not reuse person.search.information for person details dialog
  UBO-272 Fixed StackOverflowError during indexing
  Fixed JOP link
  Save publication after repair event (#326)
  deactivate ORCIDWorkEventHandler until MCR-2960 is solved
  show affiliation only for admin role
  UBO-68 use the name identifier classification also in user editor (#325)
  Issues/ubo 266 tolerate repeated lead (#322)
  UBO-265 FSU040THUL-972 Made solr field fundingType multivalued (#321)
  UBO-269 FSU040THUL-1276 Changed cite of in.host from e.g.  'Jg. 13 (2023), Heft 1, S. 1 - 10, Artikel 9489' to 'Jg. 13 (2023), Heft 1, Artikel 9489, S. 1 - 10'
  UBO-267 PublicationEventHandler now also repairs
  Added ResearcherID
  UBO-18 use position for popup close button
  UBO-18 layout finetuning and add more details (#320)
  UBO-18 unify name identifier handling (#316)
  UBO-263 FSU040THUL-405 Allow to search arbitrary realm in LocalService
  UBO-31 add kdsf editor fields and other minor adoptions from koeln
  UBO-261 FSU040THUL-1243 Added/index dynamic solr field "*_nid_text" to solr-schema.json
  UBO-96 ORCID-Anbindung optimieren (#284)
  UBO-262 Set version of pica2mods to 2.8-SNAPSHOT
  UBO-259 FSU40THUL-1218 Made solr field "origin_exact" stored
  UBO-18 unify name identifier handling (#316)
  UBO-263 FSU040THUL-405 Allow to search arbitrary realm in LocalService
  UBO-31 add kdsf editor fields and other minor adoptions from koeln
  UBO-261 FSU040THUL-1243 Added/index dynamic solr field "*_nid_text" to solr-schema.json
  UBO-96 ORCID-Anbindung optimieren (#284)
  UBO-262 Set version of pica2mods to 2.8-SNAPSHOT
  UBO-259 FSU40THUL-1218 Made solr field "origin_exact" stored
  UBO-260 FSU040THUL-972 Support fundingType facet
  UBO-256 Add random UUID to user id of MCRUser generated in MCRUserMatcherUtils#getUserNameFromModsNameElement
  UBO-258 FSU040THUL-1065 Applied requested changes
  UBO-258 FSU040THUL-1065 Mark corresponding author in mods-display.xsl
  UBO-257 Upgrade version of pica2mods to 2.7-SNAPSHOT (#307)
  UBO-253 Apply classes to segments generated by <xsl:template match="item" mode="output.category" />
  UBO-255 Upgrade to mycore to version 2022.06.3-SNAPSHOT and pica2mods to version 2.6-SNAPSHOT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants