Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamask should be enabled for other networks #1363

Closed
rstormsf opened this issue Mar 22, 2018 · 2 comments
Closed

Metamask should be enabled for other networks #1363

rstormsf opened this issue Mar 22, 2018 · 2 comments
Assignees
Labels
type: discussion Items that are primarily a discussion around a feature or issue. May evolve to be actionable. type: issue Items that document a problem or bug with an existing feature.

Comments

@rstormsf
Copy link
Contributor

https://github.com/MyCryptoHQ/MyCrypto/blob/develop/common/selectors/config/wallet.ts#L68

This is not true. Metamask works fine with any other network by using Custom RPC option.
I don't think you should only let those whitelisted networks to only work with MyCrypto...

@wbobeirne
Copy link
Contributor

You're totally right, but I actually think enabling / disabling MetaMask needs even more overhauling. Basically, we just use the network MetaMask is configured with at the time of connecting. It doesn't actually respect the dropdown in the top right, it just uses whatever you've configured in the MetaMask chrome extension. So we should probably do one of two things:

  1. Just enable Web3 all the time, since it's going to change to the right network anyway, or
  2. Disable Web3 unless its network matches the one that you're currently connected to on MyCrypto. We can check window.web3.version.network against the network chain id.

I think 1 is the best solution for ease of use, but it's important that we communicate to users when they switch networks.

@wbobeirne wbobeirne added type: issue Items that document a problem or bug with an existing feature. type: discussion Items that are primarily a discussion around a feature or issue. May evolve to be actionable. labels Mar 22, 2018
@dternyak
Copy link
Contributor

dternyak commented Apr 2, 2018

@wbobeirne How do you think we can best communicate that the user has switched networks when they unlock metamask with different network selected in the dropdown? Perhaps a simple showNotification message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: discussion Items that are primarily a discussion around a feature or issue. May evolve to be actionable. type: issue Items that document a problem or bug with an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants