Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devop/use getter contract #119

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Devop/use getter contract #119

merged 2 commits into from
Oct 5, 2018

Conversation

gamalielhere
Copy link
Contributor

Devop

  • Updated CHANGELOG.md
  • Add PR label

@gamalielhere gamalielhere changed the base branch from master to develop October 4, 2018 22:18
@gamalielhere gamalielhere added Devop Devop tasks Ready Tag for when a PR is ready to merge labels Oct 4, 2018
@gamalielhere gamalielhere added this to In progress in Development via automation Oct 4, 2018
@codecov
Copy link

codecov bot commented Oct 4, 2018 •
edited

Codecov Report

Merging #119 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #119      +/-   ##
==========================================
- Coverage     1.56%   1.54%   -0.03%     
==========================================
  Files          352     352              
  Lines         4403    4403              
  Branches       523     522       -1     
==========================================
- Hits            69      68       -1     
- Misses        3994    3996       +2     
+ Partials       340     339       -1
Impacted Files Coverage Δ
src/helpers/parseTokensHex.js 0% <0%> (-2.39%) ⬇️
src/layouts/InterfaceLayout/InterfaceLayout.vue 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffcef5d...3ebda1d. Read the comment docs.

@gamalielhere gamalielhere changed the base branch from develop to feature/ens October 5, 2018 00:38
@gamalielhere gamalielhere changed the base branch from feature/ens to develop October 5, 2018 00:39
Development automation moved this from In progress to Needs review / Reviewer approved Oct 5, 2018
@gamalielhere gamalielhere merged commit c8093e4 into develop Oct 5, 2018
Development automation moved this from Needs review / Reviewer approved to Done Oct 5, 2018
@gamalielhere gamalielhere deleted the devop/use-getter-contract branch October 5, 2018 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvhnuke kvhnuke kvhnuke approved these changes

@SteveMieskoski SteveMieskoski SteveMieskoski approved these changes

Assignees
No one assigned
Labels
Devop Devop tasks Ready Tag for when a PR is ready to merge
Projects
No open projects
Development
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gamalielhere @kvhnuke @SteveMieskoski @mew-bot