Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reimplement chainid calculation and update for bitbox v5 #206

Merged
merged 3 commits into from
Dec 10, 2018

Conversation

kvhnuke
Copy link
Contributor

@kvhnuke kvhnuke commented Dec 5, 2018

Feature

@kvhnuke kvhnuke added the Ready Tag for when a PR is ready to merge label Dec 5, 2018
@kvhnuke kvhnuke self-assigned this Dec 5, 2018
@kvhnuke kvhnuke changed the title fixes #189 reimplement chainid calculation and update for bitbox v5 Dec 5, 2018
@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

❗ No coverage uploaded for pull request base (ui/fixes@9db79d3). Click here to learn what that means.
The diff coverage is 1.58%.

Impacted file tree graph

@@             Coverage Diff             @@
##             ui/fixes     #206   +/-   ##
===========================================
  Coverage            ?   18.38%           
===========================================
  Files               ?      349           
  Lines               ?     4434           
  Branches            ?      592           
===========================================
  Hits                ?      815           
  Misses              ?     3333           
  Partials            ?      286
Impacted Files Coverage Δ
src/wallets/hardware/ledger/index.js 8.47% <0%> (ø)
src/wallets/hardware/trezor/index.js 7.69% <0%> (ø)
src/wallets/hybrid/MEWconnect/index.js 9.3% <0%> (ø)
src/wallets/WalletInterface.js 48.88% <0%> (ø)
src/wallets/software/mnemonic/index.js 9.67% <0%> (ø)
src/wallets/hardware/bitbox/index.js 7.31% <0%> (ø)
src/wallets/hardware/bitbox/digitalBitboxUsb.js 20% <0%> (ø)
src/wallets/hardware/secalot/index.js 7.5% <0%> (ø)
src/wallets/hardware/bitbox/digitalBitboxEth.js 0.9% <0.93%> (ø)
src/wallets/utils.js 33.33% <20%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db79d3...113a535. Read the comment docs.

@kvhnuke kvhnuke added the Devop Devop tasks label Dec 5, 2018
@gamalielhere gamalielhere changed the base branch from develop to ui/fixes December 10, 2018 21:43
@gamalielhere gamalielhere merged commit 232061d into ui/fixes Dec 10, 2018
@gamalielhere gamalielhere deleted the devop/wallet-update branch December 10, 2018 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Devop Devop tasks Ready Tag for when a PR is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants