Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing old Pocket Provider; adding mainnet Pocket Gateway #2600

Closed

Conversation

nymd
Copy link

@nymd nymd commented Sep 28, 2020

Feature

  • Updated CHANGELOG.md
  • Add PR label (unable to do so myself)
  • No hard-coded strings

@nymd
Copy link
Author

nymd commented Sep 28, 2020

I am unable to see the details of the failing snyk test -- let me know what needs to be changed. Thanks!

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #2600 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2600      +/-   ##
===========================================
+ Coverage    13.93%   13.95%   +0.01%     
===========================================
  Files          471      469       -2     
  Lines        18883    18843      -40     
  Branches      3220     3214       -6     
===========================================
- Hits          2632     2630       -2     
+ Misses       15401    15369      -32     
+ Partials       850      844       -6     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b7a857...4477149. Read the comment docs.

@nymd nymd marked this pull request as ready for review September 28, 2020 18:13
@stale
Copy link

stale bot commented Dec 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed within 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale PRs or Issue that are inactive label Dec 19, 2020
@gamalielhere gamalielhere removed the stale PRs or Issue that are inactive label Dec 21, 2020
@gamalielhere
Copy link
Contributor

Apologies for the delay, I'm not sure whether this is applicable. If it is, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants