Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/aug #2872

Merged
merged 13 commits into from
Mar 3, 2021
Merged

Bug/aug #2872

merged 13 commits into from
Mar 3, 2021

Conversation

gamalielhere
Copy link
Contributor

Bug

  • Updated CHANGELOG.md
  • Add PR label
  • No hard-coded strings

theqp and others added 5 commits February 16, 2021 17:05
@theqp
[README.md] Improve developer experience
be3d2b8 
By making getting started faster and simpler.
@theqp
[README.md] Fix version and make it more explicit
8cc0ac9 
- The version required was different than the one in package.json ("node": ">= 10.0.0 < 12.0.0")
- It wasn't obvious if version 8 is fine or at least 9 is required
@theqp
Remove .... from Purchase a hardware wallet
571bb96
@gamalielhere
stopping point
04bebd9
@gamalielhere
fix loading issue
78e9800
@gamalielhere gamalielhere added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge labels Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021 •
edited

Codecov Report

Merging #2872 (d504506) into develop (a11e45a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2872      +/-   ##
===========================================
- Coverage    13.38%   13.37%   -0.01%     
===========================================
  Files          491      491              
  Lines        20060    20070      +10     
  Branches      3448     3449       +1     
===========================================
  Hits          2685     2685              
- Misses       16493    16503      +10     
  Partials       882      882
Impacted Files Coverage Δ
src/layouts/InterfaceLayout/InterfaceLayout.vue 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a11e45a...1ec664a. Read the comment docs.

@gamalielhere gamalielhere merged commit 76737cb into develop Mar 3, 2021
@gamalielhere gamalielhere deleted the bug/aug branch March 3, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvhnuke kvhnuke kvhnuke approved these changes

@gesseekur gesseekur gesseekur approved these changes

@SteveMieskoski SteveMieskoski Awaiting requested review from SteveMieskoski

Assignees
No one assigned
Labels
Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gamalielhere @kvhnuke @theqp @gesseekur @mew-bot