Ui/create wallet security warning #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hsurf22 Change base, add a label, update changelog |
| @@ -17,7 +17,7 @@ import Wallet from 'ethereumjs-wallet' | |||
| export default { | |||
| data () { | |||
| return { | |||
| privateKey: '' | |||
| privateKey: '563070852154f171267e8a79111f299e42baeda3acd5f0cf82d92e5feba31dea' | |||
There was a problem hiding this comment.
Might want to remove this. Private keys should never be public. If Just add "Private Key" as an input placeholder.
|
@hsurf22 Please update the |
.fuse_hidden000107fb00000001
Outdated
| @@ -0,0 +1,2 @@ | |||
| ### Add Create Wallet warning page | |||
…rWallet/MyEtherWallet into ui/create-wallet-security-warning
| @@ -0,0 +1 @@ | |||
| export { default } from './jsonFilePasswordModal' | |||
There was a problem hiding this comment.
What is this for? It's not being imported anywhere
gamalielhere
approved these changes
Aug 14, 2018
SteveMieskoski
added
Feature
kvhnuke
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature