Ui/page faqs #58
Closed
Ui/page faqs #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #58 +/- ##
==========================================
- Coverage 1.73% 1.68% -0.06%
==========================================
Files 295 311 +16
Lines 3972 4101 +129
Branches 489 497 +8
==========================================
Hits 69 69
- Misses 3569 3698 +129
Partials 334 334
Continue to review full report at Codecov.
|
| @@ -0,0 +1,18 @@ | |||
| <template> | |||
| <div> | |||
There was a problem hiding this comment.
Whats this empty component for?
| methods: { | ||
| openFAQ: function (faqToOpen) { | ||
| var currentState = this.showFAQs[faqToOpen] | ||
| this.showFAQs.faq1 = false |
There was a problem hiding this comment.
Can't you replace this with a string instead of having multiple booleans? use v-show to check whether the article should be shown or not.
| data () { | ||
| return { | ||
| showFAQs: { | ||
| faq1: false, |
# Conflicts: # src/components/FaqContents/CouldntEverybodyPutInRandomPrivateKeys.vue # src/components/FaqContents/DoesMyEtherWalletSupportBitcoinOrOtherCoins.vue # src/components/FaqContents/HowToBuyEthereumWithUSD.vue # src/components/FaqContents/WhyDontYouMakeMeMoveMyMouseToGenerateASeed.vue # src/components/FaqContents/WithdrawingDAOTokens.vue # src/components/FaqContents/index.js # src/containers/ByMnemonicContainer/ByMnemonicContainer.vue # src/containers/ByMnemonicContainer/components/VerificationModal/VerificationModal.vue # src/containers/HeaderContainer/HeaderContainer.vue # src/layouts/CreateWalletLayout/components/CreateWalletInput/CreateWalletInput.vue # src/layouts/HelpCenterLayout/HelpCenterLayout.vue # src/router/index.js
# Conflicts: # src/components/FaqContents/HowToBuyEthereumWithUSD.vue # src/components/FaqContents/WithdrawingDAOTokens.vue
SteveMieskoski
approved these changes
Aug 31, 2018
kvhnuke
approved these changes
Sep 1, 2018
gamalielhere
approved these changes
Sep 4, 2018
|
included in Devop/fix develop #83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devop