Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in token definition for Envion token. Should be "EVN", but showing "ENV". #357

Closed
RichHorrocks opened this issue Jan 13, 2018 · 6 comments

Comments

@RichHorrocks
Copy link

As per this Stack Exchange thread: Envion token show up as ENV instead of EVN?

Looks like the definitions in the token list files just need tweaking. (Sorry for not just creating a PR!)

@ligi
Copy link
Contributor

ligi commented Jan 14, 2018

closed via #359 - PS: @Mooreel if you add "closes #issuenumber" to your commit - the issue is closed automagically on merge

@zennj
Copy link

zennj commented Jan 16, 2018

There is still ENV instead of EVN in MyEtherWallet. What i have to do? Thank You!

@ligi
Copy link
Contributor

ligi commented Jan 16, 2018

Think there is nothing you can do - the ball is now in the field of MEW @kvhnuke @tayvano

@zennj
Copy link

zennj commented Jan 16, 2018 via email

@ligi
Copy link
Contributor

ligi commented Jan 16, 2018

good question - not sure how this is handled in MEW - in WallETH there should be no duplication as long as the address does not change as there is a unique constraint on the address - but also the updating of tokens is not yet ideal I just notice - as I do not overwrite existing entries as this might have been user-input. Should add a field user_edited for this reason.

@zennj
Copy link

zennj commented Jan 16, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants