Skip to content
This repository has been archived by the owner on Nov 21, 2019. It is now read-only.

Wrong ENS contract address for testnets #509

Closed
Deozaan opened this issue May 29, 2017 · 5 comments
Closed

Wrong ENS contract address for testnets #509

Deozaan opened this issue May 29, 2017 · 5 comments

Comments

@Deozaan
Copy link

Deozaan commented May 29, 2017

Consider this low-priority since it has to do with testnet.

I wanted to test ENS on a testnet (Rinkeby) so I used MEW to check if a domain was available. It told me it was available and allowed me to place a bid. After confirmation I realized my ETH got sent to the ENS address for mainnet, which is not associated with the ENS contract on the testnet. I was careless and sent a large amount of ETH because I was expecting to get most of the ETH back once the auction closed.

No real loss to me since the test ETH isn't worth anything, but maybe MEW shouldn't allow the ENS tab to work if a testnet is selected from the dropdown menu. Or the contract address should be updated to use the correct testnet addresses.

Mainnet: 0x314159265dd8dbb310642f98f50c066173c1259b
Rinkeby: 0xe7410170f87102df0055eb195163a03b7f2bff4a
Ropsten: 0x112234455c3a32fd11230c42e7bccd4a84e02010

@tayvano
Copy link
Contributor

tayvano commented May 29, 2017

FML, thank you for catching this. Will updated ASAP and get live in the AM.

@tayvano
Copy link
Contributor

tayvano commented May 29, 2017

@kvhnuke

  1. I'm 99.999999999999% I wrote some ghetto code to prevent ENS from showing on any pages except for Ropsten and ETH. When did this get changed?

  2. Does this mean that ETC people can be accidentally bidding on names via bad addresses as well?!

  3. Your list is growing. 300 open tickets or fixing this stuff: the choice is yours and yours alone. Muahahhhahahahhaha 🙉 🙈 🙊

@kvhnuke
Copy link
Collaborator

kvhnuke commented May 30, 2017

@Deozaan I believe the problem is you selected the changed the node while on the ENS tab, for example you had the mainnet node and went to ENS tab then changed to Rinkeyby.
let me see what I can do about this.
FYI
auctions are only available on mainnet and ropsten. Rinkeby only has FIFS registrar.

@kvhnuke
Copy link
Collaborator

kvhnuke commented May 30, 2017

it show an error message now when you change the node

tayvano pushed a commit that referenced this issue May 30, 2017
@Deozaan
Copy link
Author

Deozaan commented May 30, 2017

@kvhnuke

I believe the problem is you selected the changed the node while on the ENS tab, for example you had the mainnet node and went to ENS tab then changed to Rinkeyby.

Yes, that does sound like what I did. I guess I was expecting a more AJAX-y interface where changing things in the middle of the process would update everything appropriately behind the scenes.

FYI auctions are only available on mainnet and ropsten. Rinkeby only has FIFS registrar.

And yes, I realize that now. :)

it show an error message now when you change the node

Thank you very much. I appreciate the time and effort you and @tayvano put into this.

gamalielhere pushed a commit that referenced this issue Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants