Add inside room temperature #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by mjr: https://community.openenergymonitor.org/t/heat-pump-experimentation-app-release-news/13423/19 it would be nice to include the indoor temperature too. I'm going with their suggestions for naming and coloring so this merges well with their personal setup.
This will allow it to be consumed by the MMSPHeatpump app with common behaviour wherever it is used. The autoname of `RoomTemperatureZone1` matches the attribute name used in the device info.
|
The Line 172 in 9bf1189 so we can simply incorporate it into the UI. |
|
Here is the
|
|
Merging after mjr code review. |
MrTimbones
reviewed
Feb 23, 2022
| "RoomTemperatureZone1": { | ||
| "displayOptions": { | ||
| "label": "Inside", | ||
| "color": "purple" |
There was a problem hiding this comment.
Need to add "fixed" : 1 here so that temperature is rounded to 1 decimal place.
There was a problem hiding this comment.
Oh, and the same in "TargetHCTemperatureZone1" too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by mjr:
https://community.openenergymonitor.org/t/heat-pump-experimentation-app-release-news/13423/19
it would be nice to include the indoor temperature too. I'm going with their suggestions for naming and coloring so this merges well with their personal setup.
The
autonameofRoomTemperatureZone1will cause it to tie into the device info included along with this application, but notably a user can choose a different feed if they wish by using the application configuration icon which is a wrench in the top right corner: