Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHPCS check to disallow Yoda conditions #791

Closed
JakeQZ opened this issue Oct 4, 2019 · 1 comment
Closed

Add PHPCS check to disallow Yoda conditions #791

JakeQZ opened this issue Oct 4, 2019 · 1 comment
Labels
enhancement
Milestone
4.0.0

Comments

@JakeQZ
Copy link
Contributor

JakeQZ commented Oct 4, 2019

See #778 (comment) and https://en.wikipedia.org/wiki/Yoda_conditions
@JakeQZ JakeQZ added this to the 4.0.0 milestone Oct 4, 2019
@JakeQZ JakeQZ mentioned this issue Oct 4, 2019
Closed
SignpostMarv added a commit to SignpostMarv/emogrifier that referenced this issue Oct 5, 2019
@SignpostMarv
[TASK] disable php-cs-fixer yoda conditions
dadd1da 
regarding: MyIntervals#791, MyIntervals#778 (comment)
@SignpostMarv SignpostMarv mentioned this issue Oct 5, 2019
Merged
SignpostMarv added a commit to SignpostMarv/emogrifier that referenced this issue Oct 5, 2019
@SignpostMarv
[TASK] disable php-cs-fixer yoda conditions
6a7c688 
regarding: MyIntervals#791, MyIntervals#778 (comment)
JakeQZ pushed a commit that referenced this issue Oct 5, 2019
@SignpostMarv @JakeQZ
[TASK] disable php-cs-fixer yoda conditions (#794)
6f9d875 
[TASK] Disable php-cs-fixer Yoda conditions

Regarding: #791, #778 (comment)
@JakeQZ
Copy link
Contributor Author

JakeQZ commented Oct 6, 2019

Resolved by #794.

@JakeQZ JakeQZ closed this as completed Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@JakeQZ