Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Set align attribute for <th> elements #1008

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Apr 13, 2021

Since this is set for <td> elements, it makes sense to also set it for <th>
elements, as both represent table cells. Although these attributes are
obsolete, there may still be some legacy email clients (e.g. older versions of
Outlook) that need it.

Since this is set for `<td>` elements, it makes sense to also set it for `<th>`
elements, as both represent table cells.  Although these attributes are
obsolete, there may still be some legacy email clients (e.g. older versions of
Outlook) that need it.
@JakeQZ JakeQZ added this to the 6.0.0 milestone Apr 13, 2021
@JakeQZ JakeQZ requested review from oliverklee and jjriv April 13, 2021 12:07
@JakeQZ JakeQZ self-assigned this Apr 13, 2021
@JakeQZ
Copy link
Contributor Author

JakeQZ commented Apr 13, 2021

w3resource suggests this attribute can be set on any of the table content elements (though seems to omit <caption> from its list). However, for <col> and <colgroup> it is not analogous to a CSS property, because the elements are not ancestors of the table cell elements. I'm unsure whether it is worthwhile applying the attribute to <tbody>, <thead>, <tfoot> and <tr> for it to be 'inherited'. I'm also unsure about applying it to <caption> as that was omitted from the w3resource list. But at a minimum it seems logical that it should be applied to <th> as well as <td>.

@JakeQZ
Copy link
Contributor Author

JakeQZ commented Apr 13, 2021

@oliverklee, #1004 reminded me this was one of the 'fixes' I'd promised a PR for ages ago (though I think it's an enhancement rather than a fix). Hopefully there won't be any merge conflicts with that PR.

@oliverklee oliverklee merged commit e211de0 into main Apr 13, 2021
@oliverklee oliverklee deleted the feature/th-align branch April 13, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants