[CLEANUP] Remove a redundant CSS data cache #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cache with the key `CACHE_KEY_CSS` was storing all of the parsed CSS data as a single entry, but would only ever be set once and never accessed. It does not make sense to call `inlineCss` again on the same document with the same CSS, but in any case this method clears all caches as its first action. This will reduce the memory footprint after `inlineCss` returns.
|
It's possible that this cache was once useful, but as the code has changed over the years it has become redundant. It could be made useful by making it |
oliverklee
approved these changes
Apr 14, 2021
JakeQZ
added a commit
that referenced
this pull request
Apr 19, 2021
Entry for #1018 was added at bottom of list, but entries should be in reverse-chronological order.
oliverklee
pushed a commit
that referenced
this pull request
Apr 20, 2021
Entry for #1018 was added at bottom of list, but entries should be in reverse-chronological order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache with the key
CACHE_KEY_CSSwas storing all of the parsed CSS dataas a single entry, but would only ever be set once and never accessed. It does
not make sense to call
inlineCssagain on the same document with the same CSS,but in any case this method clears all caches as its first action.
This will reduce the memory footprint after
inlineCssreturns.