Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Support more file types in the .editorconfig #1035

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

oliverklee
Copy link
Contributor

Now we also have formatting options for YAML and JSON files.

@oliverklee oliverklee added this to the 6.0.0 milestone Apr 19, 2021
@oliverklee oliverklee requested a review from JakeQZ April 19, 2021 20:53
@oliverklee oliverklee self-assigned this Apr 19, 2021
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be 4 spaces indent for .json?

.editorconfig Show resolved Hide resolved
.editorconfig Outdated Show resolved Hide resolved
@JakeQZ
Copy link
Contributor

JakeQZ commented Apr 19, 2021

Also noticed the 4 spaces indent already here for .md. Aren't we indenting .md with 2 spaces (e.g. bulleted lists in README)? Or have we not really decided?

@oliverklee
Copy link
Contributor Author

I think we have not really decided. :-)

We might need to reformat our markdown files after this.

@oliverklee oliverklee requested a review from JakeQZ April 20, 2021 11:47
@JakeQZ JakeQZ merged commit 5aeaee8 into main Apr 20, 2021
@JakeQZ JakeQZ deleted the task/more-editorconfig branch April 20, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants