[BUGFIX] Only support up to 69 atomic expressions in a selector #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With numbers from 70 and up, I get a PHP error on my local machine when running the corresponding test. |
oliverklee
force-pushed
the
bugfix/recursion-limit
branch
from
80207d9
to
9aaf3a3
Compare
JakeQZ
reviewed
Sep 16, 2021
JakeQZ
reviewed
Sep 16, 2021
oliverklee
changed the title
oliverklee
force-pushed
the
bugfix/recursion-limit
branch
from
9aaf3a3
to
21b6c52
Compare
oliverklee
force-pushed
the
bugfix/recursion-limit
branch
from
21b6c52
to
535918c
Compare
JakeQZ
approved these changes
Dec 17, 2021
Starting from 70 atomic expressions, PHP will run into the nesting level limit that was recently added to libxml: https://gitlab.gnome.org/GNOME/libxml2/-/commit/6f1470a5d6e3e369fe93f52d5760ba7c947f0cd1
oliverklee
force-pushed
the
bugfix/recursion-limit
branch
from
535918c
to
d709e52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from 70 atomic expressions, PHP will run into the nesting level
limit that was recently added to libxml:
https://gitlab.gnome.org/GNOME/libxml2/-/commit/6f1470a5d6e3e369fe93f52d5760ba7c947f0cd1