Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Update to Psalm 5.6 #1211

Merged
merged 1 commit into from
Jan 30, 2023
Merged

[TASK] Update to Psalm 5.6 #1211

merged 1 commit into from
Jan 30, 2023

Conversation

oliverklee
Copy link
Contributor

No description provided.

@oliverklee oliverklee added this to the 8.0.0 milestone Jan 23, 2023
@oliverklee oliverklee self-assigned this Jan 23, 2023
@oliverklee oliverklee changed the title [TASK] Update to Psalm 5.5 [TASK] Update to Psalm 5.6 Jan 24, 2023
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that a lot of the warnings have disappeared. I guess the new version is smarter, and smart enough to determine that these are non-issues.

@@ -1,80 +1,20 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="dev-master@">
<files psalm-version="5.6.0@e784128902dfe01d489c4123d69918a9f3c1eac5">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've seen this weird change before, and found it to be a non-issue, IIRC.

psalm.baseline.xml Show resolved Hide resolved
psalm.xml Show resolved Hide resolved
@JakeQZ JakeQZ merged commit 22d22ac into main Jan 30, 2023
@JakeQZ JakeQZ deleted the task/psalm-update branch January 30, 2023 00:09
@JakeQZ
Copy link
Contributor

JakeQZ commented Jan 30, 2023

Oops; forgot to click squash and merge after approving. Done now.

nlemoine pushed a commit to nlemoine/emogrifier that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants