[BUGFIX] Skip any style elements with null value, but still remove them #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeQZ
added
bug
php
JakeQZ
force-pushed
the
bugfix/null-nodevalue
branch
from
d3a83ba
to
e44ab87
Compare
JakeQZ
changed the title
oliverklee
requested changes
Sep 10, 2023
|
@JakeQZ Could you please rebase, resolve the merge conflicts, and repush? Thanks! |
Psalm indicates that `DOMNode::nodeValue` could be `null`, perhaps for entirely empty `<style>` elements. If such are encountered during pre-processing, still remove them from the DOM, but don't append their contents to the CSS to be inlined with extra line-breaks.
…y providing extra information. Good suggestion. I agree. It's `null|string` (nothing else), so much clearer to test for the non-null type. Co-authored-by: Oliver Klee <github@oliverklee.de>
JakeQZ
force-pushed
the
bugfix/null-nodevalue
branch
from
2b85ef9
to
a6f2c89
Compare
oliverklee
approved these changes
Sep 12, 2023
nlemoine
pushed a commit
to nlemoine/emogrifier
that referenced
this pull request
Sep 19, 2023
…em (MyIntervals#1226) Psalm indicates that `DOMNode::nodeValue` could be `null`, perhaps for entirely empty `<style>` elements. If such are encountered during pre-processing, still remove them from the DOM, but don't append their contents to the CSS to be inlined with extra line-breaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Psalm indicates that
DOMNode::nodeValuecould benull, perhaps for entirely empty<style>elements.If such are encountered during pre-processing, still remove them from the DOM, but don't append their contents to the CSS to be inlined with extra line-breaks.