Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Pin the versions of the dev dependencies #1235

Merged
merged 1 commit into from
Sep 12, 2023
Merged

[TASK] Pin the versions of the dev dependencies #1235

merged 1 commit into from
Sep 12, 2023

Conversation

oliverklee
Copy link
Contributor

This avoids CI failures when a new version of a dev dependency is released.

Fixes #1233

@oliverklee oliverklee added the dependencies Pull requests that update a dependency file label Sep 12, 2023
@oliverklee oliverklee added this to the 8.0.0 milestone Sep 12, 2023
@oliverklee oliverklee self-assigned this Sep 12, 2023
@oliverklee
[TASK] Pin the versions of the dev dependencies
89ffdaf 
This avoids CI failures when a new version of a dev dependency is
released.

Fixes #1233
JakeQZ
JakeQZ approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had wondered about still allowing later point release, but even those could break the CI build.

@JakeQZ JakeQZ merged commit b1a3382 into main Sep 12, 2023
48 checks passed
@JakeQZ JakeQZ deleted the task/pin-dev-dependencies branch September 12, 2023 16:34
@oliverklee
Copy link
Contributor Author

I had wondered about still allowing later point release, but even those could break the CI build.

That's what I was thinking, too.

nlemoine pushed a commit to nlemoine/emogrifier that referenced this pull request Sep 19, 2023
@oliverklee @nlemoine
[TASK] Pin the versions of the dev dependencies (MyIntervals#1235)
4f7e88f 
This avoids CI failures when a new version of a dev dependency is
released.

Fixes MyIntervals#1233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Inconsistency in dev tool versions selected for CI build
2 participants
@oliverklee @JakeQZ