Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Update the development tools #1273

Merged
merged 1 commit into from
Jul 7, 2024
Merged

[TASK] Update the development tools #1273

merged 1 commit into from
Jul 7, 2024

Conversation

oliverklee
Copy link
Contributor

No description provided.

@oliverklee oliverklee added the dependencies Pull requests that update a dependency file label Jul 6, 2024
@oliverklee oliverklee added this to the 8.0.0 milestone Jul 6, 2024
@oliverklee oliverklee requested a review from JakeQZ July 6, 2024 07:32
@oliverklee oliverklee self-assigned this Jul 6, 2024
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be updating the minimum version, as well as the installed version?

@oliverklee
Copy link
Contributor Author

oliverklee commented Jul 7, 2024

Should this not be updating the minimum version, as well as the installed version?

For phive install, it doesn't make any difference, as this uses the version set as installed.

Pros for keeping it like this:

  • less work when updating (only phive update, but no manual editing of the file)

Cons for keeping it like this:

  • version and installed are out of sync

I'd be fine either way, and would slightly prefer the version where only the installed version is increased as this makes the updates for me less of a hassle. Would you be okay with this?

@JakeQZ
Copy link
Contributor

JakeQZ commented Jul 7, 2024

I'd be fine either way, and would slightly prefer the version where only the installed version is increased as this makes the updates for me less of a hassle. Would you be okay with this?

Yes, that would be fine. I hadn't realized the installed version was more than just record-keeping for the local development environment.

@JakeQZ JakeQZ merged commit 9f8ded8 into main Jul 7, 2024
23 checks passed
@JakeQZ JakeQZ deleted the task/tools-update branch July 7, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants