[BUGFIX] Dynamic and static pseudo-class combined #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regular expression in `PSEUDO_CLASS_MATCHER` would match, e.g., `:hover:first-child` as a supported pseudo-class because it was consuming any non-space character as being valid in a pseudo-class name. This has been corrected so that it only consumes ‘word’ characters and hyphens.
oliverklee
approved these changes
Sep 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular expression in
PSEUDO_CLASS_MATCHERwould match, e.g.,:hover:first-childas a supported pseudo-class because it was consuming anynon-space character as being valid in a pseudo-class name. This has been
corrected so that it only consumes ‘word’ characters and hyphens.