Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Test :only-child #754

Merged
merged 1 commit into from Sep 30, 2019
Merged

[TASK] Test :only-child #754

merged 1 commit into from Sep 30, 2019

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Sep 30, 2019

And updated README to indicate it is supported.

Also removed ‘support’ for :only-child from Emogrifier class by adjusting
the PSEUDO_CLASS_MATCHER regex, so that rules with such selectors will be
copied to a <style> element. (It is not supported in that class.)

Closes #747.

Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you please rebase?

And updated README to indicate it is supported.

Also removed ‘support’ for `:only-child` from `Emogrifier` class by adjusting
the `PSEUDO_CLASS_MATCHER` regex, so that rules with such selectors will be
copied to a `<style>` element.  (It is not supported in that class.)

Closes #747.
@JakeQZ
Copy link
Contributor Author

JakeQZ commented Sep 30, 2019

Could you please rebase?

Have done.

@oliverklee oliverklee merged commit f6498b6 into master Sep 30, 2019
@oliverklee oliverklee deleted the test/only-child branch September 30, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for remaining supported pseudo-classes
2 participants