Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Support: first-of-type #757

Merged
merged 1 commit into from Sep 30, 2019
Merged

[FEATURE] Support: first-of-type #757

merged 1 commit into from Sep 30, 2019

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Sep 30, 2019

Part of #748.

@JakeQZ JakeQZ added this to the 3.0.0 milestone Sep 30, 2019
@JakeQZ JakeQZ self-assigned this Sep 30, 2019
@JakeQZ
Copy link
Contributor Author

JakeQZ commented Sep 30, 2019

Will need rebasing when #756 is merged.

@JakeQZ JakeQZ mentioned this pull request Sep 30, 2019
Merged
oliverklee
oliverklee approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you please rebase?

@JakeQZ
Copy link
Contributor Author

JakeQZ commented Sep 30, 2019

Have rebased.

@JakeQZ
Copy link
Contributor Author

JakeQZ commented Sep 30, 2019

I'll merge this so that I can move on to other tasks without more rebasing needed - @oliverklee, let me know if you spot there were any mistakes made resolving conflicts for the rebase.

@JakeQZ JakeQZ merged commit de1ac96 into master Sep 30, 2019
@JakeQZ JakeQZ deleted the feature/first-of-type branch September 30, 2019 18:58
JakeQZ added a commit that referenced this pull request Sep 30, 2019
@JakeQZ
[CLEANUP] Clarify :…-of-type support in README
4d12244 
Added “`:first-of-type` (without a type)” and “`:last-of-type` (without a type)”
to unsupported selectors list – missed in #757/#758.
@JakeQZ JakeQZ mentioned this pull request Sep 30, 2019
Merged
oliverklee pushed a commit that referenced this pull request Sep 30, 2019
@JakeQZ @oliverklee
[CLEANUP] Clarify :…-of-type support in README (#766)
08eb503 
Added “`:first-of-type` (without a type)” and “`:last-of-type` (without a type)”
to unsupported selectors list – missed in #757/#758.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels
documentation enhancement unit tests needed
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JakeQZ @oliverklee