Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Support minified combinator with pseudo-component #903

Merged
merged 1 commit into from Jun 15, 2020

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Jun 15, 2020

Minified selectors such as ul>:hover would cause an exception in debug mode,
and otherwise would always be copied to the <style> element even if they could
never match anything, whereas, e.g., ul > :hover would be treated as intended.

Minified selectors such as `ul>:hover` would cause an exception in debug mode,
and otherwise would always be copied to the `<style>` element even if they could
never match anything, whereas, e.g., `ul > :hover` would be treated as intended.
@JakeQZ JakeQZ added the bug label Jun 15, 2020
@JakeQZ JakeQZ added this to the 5.0.0 milestone Jun 15, 2020
@JakeQZ JakeQZ requested a review from oliverklee June 15, 2020 18:48
@JakeQZ JakeQZ self-assigned this Jun 15, 2020
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@oliverklee oliverklee merged commit 38cbe53 into master Jun 15, 2020
@oliverklee oliverklee deleted the bugfix/minified-combinator-pseudo branch June 15, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants