Ui/menubar #88
Merged
Ui/menubar #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weisJ
force-pushed
the
ui/menubar
branch
3 times, most recently
from
f9f1297
to
8caf874
Compare
39 tasks
marko-radosavljevic
approved these changes
Nov 29, 2020
weisJ
commented
Nov 29, 2020
| } | ||
|
|
||
| private ActionContext getContext() { | ||
| /* |
There was a problem hiding this comment.
Converting to a draft because this Todo needs to be addressed before merging.
…ApplicationContext is passed which simply holds some information about application modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the application menubar which is populated with registered actions.
For a start I have created an empty scaffolding of all menu items which are available in the old application.
Grouping and position of individual items should be adjusted down the line as the current setup (which is taken directly from the legacy app) seems a bit random at some places.
The scaffold menu items currently dont do anything.
Most icons are still missing as I don't want to put energy into searching for the correct icons in the legacy files and due to the fact that the new icons aren't ready yet.