Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'mov' video format #18

Closed
wants to merge 1 commit into from
Closed

Conversation

Bad3r
Copy link

@Bad3r Bad3r commented Nov 12, 2022

Hi,
I hope all is going well. I noticed that *.mov videos get opened in the browser instead of the video player.

Example: https://user-images.githubusercontent.com/80150109/170867699-9ff15056-e34e-47ca-b86a-77386c08f671.mov

@Bad3r
Copy link
Author

Bad3r commented Nov 12, 2022

There might be a better way to do this by getting all video formats supported by mpv and/or vlc

@odnar-dev
Copy link
Member

maybe we should add all formats from : https://github.com/mpv-player/mpv/blob/master/etc/mpv.desktop

@Bad3r
Copy link
Author

Bad3r commented Nov 13, 2022

@odnar-dev that contains list of MIME types and not just extensions. There might be another way to get the extensions, unless you know of a way to get the MIME type from the video URL?

Also on another note, instead of using a complex conditional; I think Bash case statement would be a better fit here

This was referenced Jun 18, 2023
@odnar-dev
Copy link
Member

hi @Bad3r, i hope you are okay
i added your changes to dev branch for now, and opened a new issue to find a better way to detect mime typs of urls.
by the way you can always force an URL to be opened in the player menu by typing "!p"

image

image

@Bad3r
Copy link
Author

Bad3r commented Jun 21, 2023

hi I am doing well! how about yourself?

thanks for the tip I'll take another look when I get a chance to see if there is a better way to do this.

@odnar-dev
Copy link
Member

i am good , just busy with an internship.
i will be closing this pr for now, any further discussion , ideas related to this should be in #27

@Bad3r
Copy link
Author

Bad3r commented Jun 28, 2023

Thats awesome! sounds good

@Bad3r Bad3r closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants