Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add (optional) logger to log failed token fetch requests #4

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Add (optional) logger to log failed token fetch requests #4

merged 2 commits into from
Feb 1, 2019

Conversation

frankverhoeven
Copy link
Contributor

Allows a logger to be injected so failed token requests can be logged.
Also updated phpcs to use the mos/cs package.

@frankverhoeven frankverhoeven added the enhancement New feature or request label Feb 1, 2019
Feijs
Feijs reviewed Feb 1, 2019
View reviewed changes
Copy link

@Feijs Feijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the logs written to in this case?

src/TokenManager/Jwt.php Outdated Show resolved Hide resolved
@frankverhoeven
Copy link
Contributor Author

Where are the logs written to in this case?

Nowhere, this has to configured in the app using this package (the monolith)

@Feijs
Copy link

Feijs commented Feb 1, 2019

Nowhere, this has to configured in the app using this package (the monolith)

:friday:

@Feijs Feijs merged commit 2bc2e29 into master Feb 1, 2019
@Feijs Feijs deleted the jwt-manager-logger branch February 1, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Feijs Feijs Feijs approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frankverhoeven @Feijs