Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Fix failing test suite #32

Merged
merged 5 commits into from
Apr 16, 2024
Merged

🔧 Fix failing test suite #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f5a114a
:wrench: Updated checkout version
zwaans Apr 16, 2024
c48444e
:alembic: Update phpunit xml
zwaans Apr 16, 2024
fa361f8
:alembic: Disable failOnWarnings
zwaans Apr 16, 2024
aea5ef3
:alembic: Tweak phpunit bootstrap and schema
zwaans Apr 16, 2024
9d3f74f
:alembic: Experiment with test suffix
zwaans Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ jobs:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: php-actions/composer@v6
- name: PHPUnit Tests
uses: php-actions/phpunit@v3
with:
configuration: phpunit.xml
php_version: 8.2
bootstrap: vendor/autoload.php
test_suffix: Test.php
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test suffix is what was breaking the pipeline. Its original value in the phpunit action is set to Test.php, .phpt which breaks it since phpunit no longer supports the separator in there which is why I set it to just Test.php for now.

4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
},
"require-dev": {
"fakerphp/faker": "^1.13",
"mockery/mockery": "^1.4",
"phpunit/phpunit": ">=9.5",
"roave/security-advisories": "dev-latest"
"roave/security-advisories": "dev-latest",
"mockery/mockery": "^1.6"
},
"autoload": {
"psr-4": {
Expand Down
18 changes: 8 additions & 10 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 2 additions & 7 deletions phpunit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,13 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="./vendor/phpunit/phpunit/phpunit.xsd"
bootstrap="vendor/autoload.php"
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.2/phpunit.xsd"
colors="true"
testdox="true"
>
<testsuites>
<testsuite name="Unit">
<directory>./tests/</directory>
</testsuite>
</testsuites>
<coverage/>
<source>
<include>
<directory suffix=".php">./src</directory>
</include>
</source>
</phpunit>