chore(tooltip): Added tests for gux-tooltip-title component #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-1408 |
|
Any reason you're going for just e2e tests alone here? |
It looks like some of the tests to test for tooltip visibility wouldn't work in a spec file without breaking the gux-tooltip-text component at runtime. I saw that sometimes components in the spark repo don't have a spec file and rely solely on a e2e test file. I thought perhaps this could be one of those components where write all tests within an e2e test file made sense. |
jason-evans-genesys
changed the title
321gillian
approved these changes
May 24, 2024
| @@ -86,7 +86,10 @@ export class GuxTruncate { | |||
| }} | |||
| > | |||
| <span | |||
| class="gux-truncate-slot-container" | |||
| class={{ | |||
| 'gux-overflow-hidden': this.needsTruncation(), | |||
There was a problem hiding this comment.
I believe this is backwards compatible.
321gillian
approved these changes
Jun 4, 2024
✅ Closes: COMUI-1408 chore(truncate): Added tests for checking if tooltip is visible or not ✅ Closes: COMUI-1408 chore(tooltip): Added visibility tests for gux-tooltip within a gux-tooltip-text tag ✅ Closes: COMUI-1408 chore(truncate): Removed unneeded page is defined expect statement in tests ✅ Closes: COMUI-1408 chore(truncate): Added more tests ✅ Closes: COMUI-1408 chore(truncate): Removed console log statement ✅ Closes: COMUI-1408 chore(truncate): Added truncation text check test ✅ Closes: COMUI-1408 chore(tooltip): Added test for truncation for tooltip-title component ✅ Closes: COMUI-1408 chore(tooltip): Added more tests for tooltip-title component ✅ Closes: COMUI-1408 chore(tooltip): Fixed some snapshot tests for tooltip-title ✅ Closes: COMUI-1408
jason-evans-genesys
force-pushed
the
feature/COMUI-1408
branch
from
a830b9f
to
2c256c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Closes: COMUI-1408
Let me know if there are any other tests you think I should write for
gux-truncateandgux-tooltip-title.