Use JSZip, add ability to specify icons manually, return stream instead of buffer #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSZip is maintained actively, while AdmZip is not. I chose to return a stream instead of a buffer, this of course is a breaking change. Returning a buffer is async with JSZip and this would be a breaking change, too.
I also added the ability to specify the icons manually, now you don't need to have a local directory with the icons and can just read them from the memory.