General Guide

[Jood80]

Reviewing code

• Every PR must be approved by all the team in order to be merged to the dev branch.
• Don't resolve a comment on your PR but only comment back (reply), and let the comment writer resolve it

Working on a task

1. Branch naming:

• branch names shall follow this style feat/issueNumber-issue-name (e.g. 102-login-page)
• pick one of those as for the first part of your branch name feat, bugfix, hotfix, refactor

2. Committing changes:
   • any changes that are not related to the task (issue) or are not mentioned in it will not be accepted (if there is a bug that is making your task fail, open an issue for it and start working on fixing it)
   • make sure to fire npm run lint after finishing your task
   • commits must always be descriptive and must follow the conventions mentioned here
   • every and each commit must relate to the PR number at the end, (e.g feat(login): create login page (#PR_number))
3. Use of labels and projects
   • once started working on a task label the issue In Progress and move it to the In progress column in its project.
   • label the PR Review Needed if you need it to be reviewed.
   • label the PR In Progress if you still working on it.
   • PRs must be labeled with Changes Requested once a change is requested and once you finished working on a task give it Accepted label.
   • label the PR Completed after it's got into validation and tested successfully and close the issue
   • any Accepted PR can be merged to the dev branch. Only Completed tasks can be merged into master.
   • once a PR or an issue is closed it shall not be reopened. if there exists a bug related to a specific issue that was closed, another issue is to be opened and labeled Bug.
   • if there exists some critical bug that is causing the project to crash an issue with the labels Bug, Urgent, and priority has to be opened