Feedback: code review comments #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
view size, texture files
style: css footer styling
fix: scrolling during game
Added login and registration code (not working yet)
fix: unmounting event listener
Win conditions
Game room: fixed styling
fix: disposing players after leaving game.
jump is back in town
lights2 cleanup
fix: remove dead code/console logs
Game room: Players can join a specific game room
Revert "Game room: Players can join a specific game room"
niLYu
force-pushed
the
code-review-feedback
branch
from
5ddb0fb
to
787e243
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please use the files changed tab to come up with issues / todos and the close this PR