Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganize by lang-code #11

Closed
wants to merge 1 commit into from

Conversation

JarbasAl
Copy link

i have been recording a few samples for "hey computer", the thing is that in portuguese the "hey" can be lots of different things, things fit much more nicely together if we organize the repo like this

Screenshot_20190917_205056

lang-code/wake_word works with word variations much more naturally than wake_word/lang-code

using "hey computer" has an example, in general you would say "ei computador", but in northern portugal you are more likely to say "ó computador" while in brazil you might say "oi computador", this is not a matter of accent, those are different words, and the data needs to be labelled better to take this into account

@el-tocino
Copy link
Collaborator

Based on your example above, and other thought, closing this. Neither your change or the current method handles those, but a lang-wakeword or wakeword-lang format would.

@el-tocino el-tocino closed this Nov 1, 2019
@JarbasAl
Copy link
Author

JarbasAl commented Nov 1, 2019

Based on your example above, and other thought, closing this. Neither your change or the current method handles those, but a lang-wakeword or wakeword-lang format would.

i don't understand, what this does is lang-wakeword, my example shows what it is solving with the hey_computer word, lang-wakeword allows to do it properly

@JarbasAl
Copy link
Author

JarbasAl commented Nov 1, 2019

wakeword_lang would not make much sense i think,

hey_computer
   - pt
      - 3 folder here for variations
   - en
       - hey computer

lang_wakeword (this PR) looks better IMHO

pt
  - variation 1
  - variation 2
  - varation 3
en
 - hey computer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants