Guarantee sorted results from IntentDeterminationEngine.determine_intent #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enumerate all possible parse results if context or regex entities are in play.
This was referenced Jul 5, 2021
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 10, 2021
cherry pick of mycroft-core/pull/2915 waiting for MycroftAI/adapt/pull/137 Added to docstring to explain why the method took a list of utterances instead of a single utterance. Fixed a bug where the highest confidence from the Adapt parser is different than the highest confidence from the Adapt intent matcher.
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 10, 2021
cherry pick of mycroft-core/pull/2915 waiting for MycroftAI/adapt/pull/137 Added to docstring to explain why the method took a list of utterances instead of a single utterance. Fixed a bug where the highest confidence from the Adapt parser is different than the highest confidence from the Adapt intent matcher.
forslund
previously approved these changes
Jul 12, 2021
|
My only comment is that this makes Adapt no longer "greedy" when doing the sorting. Is this acceptable? If so, should comments be added to this effect? |
Also updating comment to call out scenarios in which the algorithm is greedy vs when it's more thorough.
|
@ChristopherRogers1991 updated the comments on IntentDeterminationEngine to incorporate the fact that we're only sometimes greedy. Also bumped to 0.5.0. |
|
I think you probably meant to tag @chrisveilleux. |
Yup, my bad! Thanks other Chris! |
chrisveilleux
approved these changes
Jul 19, 2021
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 21, 2021
cherry pick of mycroft-core/pull/2915 waiting for MycroftAI/adapt/pull/137 Added to docstring to explain why the method took a list of utterances instead of a single utterance. Fixed a bug where the highest confidence from the Adapt parser is different than the highest confidence from the Adapt intent matcher.
JarbasAl
pushed a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
Jul 22, 2021
cherry pick of mycroft-core/pull/2915 waiting for MycroftAI/adapt/pull/137 Added to docstring to explain why the method took a list of utterances instead of a single utterance. Fixed a bug where the highest confidence from the Adapt parser is different than the highest confidence from the Adapt intent matcher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enumerate all possible parse results if context or regex entities are in play.
Description of what the PR does, such as fixes # {issue number}
Fixes IntentDeterminationEngine.determine_intent does not return sorted results #136
Description of how to validate or test this PR
Explicit unit test added:
IntentEngineTests.testResultsAreSortedByConfidence./run_tests.shWhether you have signed a CLA (Contributor Licensing Agreement)
Signed