Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to code that's been removed #121

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

strugee
Copy link
Contributor

@strugee strugee commented Jul 5, 2019

@strugee
Copy link
Contributor Author

strugee commented Jul 5, 2019

Actually, looks like this whole document might need to be reworked. The section about converting to use decorators is outdated too, since as of that commit the template already uses decorators.

@forslund
Copy link
Collaborator

forslund commented Jul 5, 2019

You're quite right. The entire document needs to be updated. If you like to tackle that as well we can hold off on merging this. Otherwise I think this can be merged when the CLA lands and we can continue the work in separate PR's.

@strugee
Copy link
Contributor Author

strugee commented Jul 5, 2019

Honestly I'm just working through the introductory materials myself so I'm not sure how much I'll really be able to explain :P

Why don't you go ahead and merge this when I'm done with the CLA process and I'll file a followup issue to clean the rest up? Then if/when I feel like I've got enough experience I can go ahead and do it myself, or if someone gets to it before me they can take it and run with it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants