Remove usage of "emitter" #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to have been missed when switching from using self.emitter to self.bus.
|
Nice one, thanks :) Have added a separate ticket to come back to the 401 pairing thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
self.emitter was still used to try to call pairing, this seems to have been missed when switching from using
self.emittertoself.bus.The code is rarely used but should trigger pairing if wolfram alpha is called when unpaired and wolfram response can't be fetched through Mycroft Home. Possibly the functionality should be removed?
This also fixes an incorrect return value after that showed up when the main issue was resolved.
Type of PR
Testing
Run the skill in an unpaired state and enter a question on the CLI, an error message should not be seen in the log.