Added wheel and pytest as dependencies #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
|
Hey, great addition to the readme! My only suggestion is to bump the install of wheel to first in the list of commands as the |
|
Thanks as always, @adocampo! I went ahead and moved wheel up, per @krisgesling, and I'm gonna go ahead and merge now. Leaving all 3 commits, as the first 2 do different things and the 3rd would overwrite your authorship. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified README to make sure contributors are installing these tools inside the virtual environment, so global-wide pytest and python-wheel won't interfere.