Optimized "end-of-corpus" handling (fixing issue #38) #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some Python docstrings (#67) Sync with origin repo.
|
Hi @krisgesling 👋 . |
krisgesling
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When last phrase of corpus has been recorded the last phrase will be shown again and again and again ... and an exception is logged on the commandline (see issue #38).
Now following phrase in shown in frontend when corpus has been completely recorded.Type of PR
Testing
Use a small corpus file and record all phrases. Check console log when last recorded is done if no exception is logged. Text
*no more phrases in corpus to record*should be shown in frontend.Documentation
Docstring in backend has been updated.