Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress ls no such file error message #208

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

NoamDev
Copy link
Contributor

@NoamDev NoamDev commented Jul 12, 2020

  • Description of what the PR does, such as fixes # {issue number}
    When there are no dlls to copy, it seems like there's an error.
    This change would supress the error message but wouldn't harm functionality.
  • Description of how to validate or test this PR
    The best way would be to check the method changed individually, in case there are dlls to copy and in case there are none.
  • Whether you have signed a CLA (Contributor Licensing Agreement)
    Yes

When there are no dlls to copy, it seems like there's an error.
This change would supress the error message but wouldn't harm functionality.
@NoamDev
Copy link
Contributor Author

NoamDev commented Jul 12, 2020

@forslund This one was for you, I didn't want the CI you're gonna build to fail because of that nonsense.
The checks failed, with no reason as far as I can tell.
Can someone force a recheck or is it pointless?
Edit: It doesn't seem to a coincidence but more like a problem with the task "shared".
Anyway, my changes didn't cause it.

@forslund
Copy link
Collaborator

forslund commented Jul 12, 2020

I wonder if the correct way to do it is to remove the move dll step when doing static windows builds?

or do you see it when doing shared build as well?

@forslund forslund added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Jul 12, 2020
@NoamDev
Copy link
Contributor Author

NoamDev commented Jul 12, 2020

I finished compiling and got exactly the same result with winbuild_shared.
Maybe it happens only in some cases/ubuntu versions and maybe it is related to the fact that I'm using wsl.
Anyway, removing the dll step will resolve nothing.

@NoamDev
Copy link
Contributor Author

NoamDev commented Jul 12, 2020

Even in the improbable scenario in which this happens only in wsl, it solves this specific problem and does not harm anyone else.
So why not;)

@forslund
Copy link
Collaborator

Agreed, Merging this and making a note to look at that again. Something may be wrong if nothing is ever copied...

@forslund forslund merged commit 2552136 into MycroftAI:development Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants