New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace cmudict-0.4 dictionary with amepd. #36
Conversation
I have added Mycroft in the latest master commit to amepd, along with several new words and some pronunciation fixes. |
Great! I'm currently out camping, but I'll update the PR with your updates when I return home (tomorrow evening, sunday at the latest) |
I'm also pulling this down to play with it. I'll try to find some time to provide feedback. |
Not a problem with the dictionary, but as minic is removing
a. word ends with NOTE: This also needs to handle words like |
Is 1 worse with the new dict than with the old cmudict-0.4? Can you give an example where mimic fails? |
Just noticed the examples. Sorry about that :) |
Not worse -- those words I gave as examples are where stripping out |
Ok. I'll have to dig into the code and see if we can improve this. At least for systems with larger memory... |
If I am not mistaken @rhdunn is taking care of the apostrophes in #39. If I understand this properly, @forslund you rebuilt the cmulex using the amepd dictionary and this pull request has the resulting models. To build this you used the lang/cmulex/make_cmulex script, replacing manually the lang/cmulex/festival/lib/dict/cmudict-0.4.scm file by the amepd dictionary, am I right? |
@zeehio basically, yes. I changed the Makefile target for cmudict-0.4.out so that it's currently
and rebuilt the outfile. Also I created a no-setup target in the
So the files weren't overwritten. |
@forslund, keeping the first commit of this PR does not make much sense. Could you please squash them into one commit? As I see it, feel free to merge :-) |
Amepd (The american pronounciation dictionary) is a dictionary based on cmudict-0.7 with many additions. The source dictionary is available at http://github.com/rhdunn/amepd. The updated dictionary is based on amepd from May 6th.
Current coverage is 15.85%@@ master #36 diff @@
==========================================
Files 89 89
Lines 9487 9487
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1504 1504
Misses 7983 7983
Partials 0 0
|
After doing the manual squash I noticed the "squash and merge" github button. Anyway it's squashed and merged now. |
If I had known it existed I'd have merged myself |
What it is
Amepd (The american pronounciation dictionary) is a dictionary based on cmudict-0.7 with many additions. The source dictionary is available at http://github.com/rhdunn/amepd.
This would resolve the wrongly pronounced words listed in #15. @rhdunn the maintainer of the dictionary will add "Mycroft" to the dictionary in the next update and this should not be pulled before that time.
In the meantime it would be great if the dictionary was used and verified.