Bugfix/issue 1014 #1018
Merged
Bugfix/issue 1014 #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
==== Fixed Issues ==== ==== Tech Notes ==== This PR corrects a couple of small issues led to skills being left in memory when. - Handler for `stop.mycroft` weren't removed from event emitter when skill shut down. Now is added using `self.add_event()` - registered intent list `self.events` created a circular reference that python couldn't resolve a live so this is now deleted at shutdown - Timers in scheduled skills weren't terminated properly. Now if the timer is alive it will be joined ==== Documentation Notes ==== Registring event handlers should use `self.add_event` instead of `self.emitter.on()` To make sure they are cleaned up when skill is terminated. ==== Localization Notes ==== NONE - point to new strings, language specific functions, etc. ==== Environment Notes ==== NONE - new package requirements, new files being written to disk, etc. ==== Protocol Notes ==== NONE - message types added or changed, new signals, APIs, etc.
forslund
added
the
CLA: Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix trailing references causing memory leak
==== Fixed Issues ====
#1014 If not resolved atleast vastly improved
==== Tech Notes ====
This PR corrects a couple of small issues led to skills being left in memory when.
stop.mycroftweren't removed from event emitter whenskill shut down. Now is added using
self.add_event()self.eventscreated a circular reference thatpython couldn't resolve a live so this is now deleted at shutdown
timer is alive it will be joined
==== Documentation Notes ====
Registering event handlers should use
self.add_eventinstead ofself.emitter.on()To make sure they are cleaned up when skill isterminated.