Fixes #1547 Addition of say as tts engine #1548
Conversation
|
Hello @bhaveshAn! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on April 19, 2018 at 21:45 Hours UTC |
mycroft/tts/say_tts.py
Outdated
| from mycroft.tts import TTS, TTSValidator | ||
|
|
||
|
|
||
| class Say(TTS): |
There was a problem hiding this comment.
Since say is pretty vague in the context of text to speech (even though that's what it's called), would you mind renaming it to something like RSynth? This also gives people a better search term to use to download it.
mycroft/tts/say_tts.py
Outdated
|
|
||
| def validate_connection(self): | ||
| try: | ||
| subprocess.call(['say', 'hello']) |
There was a problem hiding this comment.
This actually produces the audio hello every time the device boots up or speaks. This should be changed to something that doesn't output audio. Perhaps a check of distutils.spawn.find_executable('say') would work.
|
Hi @MatthewScholefield please review the code. |
|
So, I just realized, you could also be referring to the |
|
Initially say used in mac. But I am able to use say on linux as well. |
|
With no CLA I cannot accept these changes. I'm closing unmerged, but am happy to revisit if you would like to request a CLA via https://mycroft.ai/cla |
|
@penrods I can't get email for cla. |
|
I checked and the CLA request should be heading your way. Search your email for something from the Hellosign service. |
|
@penrods I have signed it. Please check |
penrods
added
the
CLA: Yes
krisgesling
added
Type: Enhancement - proposed
|
Hi there, not sure why this didn't get merged previously, but we're planning to add a plugin system for audio backends, STT and TTS services. This system will allow users (or developers configuring Mycroft for use in other projects) to pull in these services as they're needed rather than having them all included by default on every Mycroft installation. The aim is to keep mycroft-core lighter but still provide the same level of features and customization through the provision of these plugins. So I'm going to close this PR but only because it won't need to be included in mycroft-core. We'll be transitioning all of these out to be independent plugins as per #2701 and can include this service in that work. Thanks |
Description
Fixes #1547 Addition of say as tts engine
How to test
(Description of how to validate or test this PR)
Contributor license agreement signed?
CLA [ ] (Whether you have signed a CLA - Contributor Licensing Agreement
@forslund @penrods @aatchison Please review. thanks.