Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI screen corruption #1704

Merged
merged 4 commits into from
Jul 30, 2018
Merged

Fix CLI screen corruption #1704

merged 4 commits into from
Jul 30, 2018

Commits on Jul 24, 2018

  1. Fix CLI screen corruption

    The CLI would often have temporary screen corruption.  This reworks
    several things to correct that issue, although it looks like the
    ultimate cause was drawing to the screen while in the middle of
    waiting on a VT100 ESC keycode sequence.
    
    * Rearchitected all screen drawing to run in a single thread.  Now
      call set_screen_dirty() instead of draw_screen()
    * Added a lock on accessing the various Log buffers, preventing
      changes to the buffer in the middle of a redraw
    * Modified key reading logic when ESC character is received.  Now
      uses a 1 second timeout if no subsequent keycodes are sent
    penrods committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    cac358f View commit details
    Browse the repository at this point in the history
  2. Fix PEP8 errors

    penrods committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    ca84bae View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2018

  1. Catch several special exceptions

    Curses throws exceptions in some cases during get_wch(), such as
    when you Ctrl+Z suspend the CLI the resume the process.
    
    Also moved Ctrl+C processing into this exception handler.
    penrods committed Jul 28, 2018
    Configuration menu
    Copy the full SHA
    fbdf5e6 View commit details
    Browse the repository at this point in the history
  2. Fix Codacy issues

    penrods committed Jul 28, 2018
    Configuration menu
    Copy the full SHA
    5641f57 View commit details
    Browse the repository at this point in the history