Bugfix/write pho file #1720
Merged
Bugfix/write pho file #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forslund
added
Type: Bug - complex
CLA: Yes
Change Mimic.get_tts() to return phonemes as string instead of bytes
forslund
force-pushed
the
bugfix/write-pho-file
branch
from
0b7dcf3
to
65ee8ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing #1716 I noticed the issue with the Mimic tts that prompted the PR. Big shout-out and thanks to @ndarilek for pointing me to this issue!
How to test
Set TTS to mimic and run a simple command, check that the audio log doesn't show an error.
Contributor license agreement signed?
CLA [Yes]