Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance tester output #1755

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Enhance tester output #1755

merged 1 commit into from
Aug 21, 2018

Conversation

penrods
Copy link
Contributor

@penrods penrods commented Aug 21, 2018

Description

Several visual changes to the logs (no functional difference)

  • Added 'with' to close test_case_file, quieting warning
  • Highlight Mycroft's utterannces in output and moved print to fix order of printing
  • Better highlight sending a response
  • Highlight the test utterance

How to test

Run skilltester, look at output

Contributor license agreement signed?

CLA [ X ] (Whether you have signed a CLA - Contributor Licensing Agreement

Several visual changes to the logs (no functional difference)
* Added 'with' to close test_case_file, quieting warning
* Highlight Mycroft's utterannces in output and moved print to fix order of printing
* Better highlight sending a response
* Highlight the test utterance
@penrods penrods added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Aug 21, 2018
@forslund
Copy link
Collaborator

Tested and working as intended, looks nice. Merging

@forslund forslund merged commit ea2ef5d into dev Aug 21, 2018
@forslund forslund deleted the feature/enhance-tester-output branch November 4, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants