Fix path in recent locale support #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent changes to support the 'locale' directory were incorrectly joining the os.walk() path and filename, resulting in double-directories, like "./vocab/en-us/./vocab/en-us/Something.voc"
penrods
added
the
CLA: Yes
|
Works and looks fine. merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes to support the 'locale' directory were incorrectly
joining the os.walk() path and filename, resulting in double-directories,
like "./vocab/en-us/./vocab/en-us/Something.voc"
How to test
I noticed then when running the skill tester (go into a skill directory like
cd /opt/mycroft/skills/mycroft-joke.mycroftaiand runpython -m test.integrationtests.skills.runner .It fails before this PR, works afterwards.Contributor license agreement signed?
CLA [ X ] (Whether you have signed a CLA - Contributor Licensing Agreement