Bugfix/audioservice invalid utterance #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
play would happily send on None to the audioservice even though it's not a proper sentence. This will handle None and default it to an empty string.
If an utterance is provided already the method shall not try to override it with a stored utterance.
|
Hello @forslund! Thanks for submitting the PR.
|
|
Codacy seems to have hung. I'm going ahead with the merge |
penrods
added
the
CLA: Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CommonPlaybackSkill may send None as an utterance when invoking the audioservice.play() method. This fix makes sure that None is handled in a sane way.
Additionally the CPS_play method has been altered to not add an utterance if the skill tries to add one.
How to test
Try invoking the NPR_news skill with "what's the news" and make sure it works.
Contributor license agreement signed?
CLA [Yes]