New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use XDG Base directories for settings, cache and runtime data #2578
Conversation
Voight Kampff Integration Test Failed (Results) |
Hello @PureTryOut! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-01-08 20:50:15 UTC |
3ff46b0
to
f7807cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still haven't finished writing the specs for this feature you've already implemented so I'll start by sending some of the notes I made on this PR this weekend.
cf1055e
to
7a3f104
Compare
Woops, sorry. I got too excited for this 🙈 |
Voight Kampff Integration Test Failed (Results) |
Voight Kampff Integration Test Failed (Results) |
Voight Kampff Integration Test Failed (Results) |
Made the changes, let's see! Honestly, VK is one big mystery to me. |
Just realized this will bork (and did bork) the VK test runner since it moves the identity file (and doesn't restore it)... Could you edit the Jenkinsfile@L60 to be to make sure the identity file isn't moved from the shared volume. |
810e3de
to
db5a3eb
Compare
Hmm, still failing. Seems testing the skills times out or something? |
Right now the identity file is broken (I think) so many of the tests using it (weather, Q and A) are failing and it gets 10 seconds timeout of all of those. We can retry when the identity file for VK is restored |
New identity file in place, triggered a new run 🤞 |
Uh, seems it ignores the updated Jenkinsfile file and keeps mounting the file to |
Seems like Jenkins doesn't trust you :( I'll see if I can figure out how to make it trust you / this change of the Jenkinsfile |
Moved from .mycroft to XDG folder
If you make changes don't push to this branch since it'll destroy the jenkins identity file :/ ... Update in a branch and let me know. I'll pull them into the branch for the PR I created |
Done, my branch Too bad another review with more requested changes comes in so late 😢 |
Tried out that branch on OVOS. The following error pops up;
|
Right! To manu different branches / tries because of this VK stuff. Will check/test the other one for you. |
Closing this as it's being replaced by #2794 and it seems it causes confusion by being still open. It's the same changes, but with stuff to make VK work (which I don't have permissions for in this PR). |
Description
This makes Mycroft use the XDG Base Directory specification.
Data is now saved to:
$XDG_CONFIG_DIR/mycroft
, which most of the time equals to~/.config/mycroft
$XDG_DATA_DIRS/mycroft
, which most of the time equals to~/.local/share/mycroft
$XDG_CACHE_HOME/mycroft
, which most of the time equals to~/.cache
Since this changes the default location of pretty much everything, please test it well!
Goal is to support and read from the old
~/.mycroft
location if it already exists, but save to the XDG Base Directories and read from it on new installations.Together with #2559 this should be full XDG Base Directory compliance.
How to test
First of all, run this PR with an existing installation, and check if everything is loaded from the usual locations. Then shut it down and restart to make sure it has saved to the new locations.
Then, completely remove any trace of Mycroft settings from your system. Easiest would be to fully deinstall (remove
/opt/mycroft
), remove~/.mycroft
, and the XDG Base directories mentioned above.Now reinstall Mycroft (with this PR applied) and start and connect it. Check if
~/.mycroft
is not created anymore and~/.config/mycroft
,~/.local/share/mycroft
and~/.cache/mycroft
are with the correct files and directories in them.Contributor license agreement signed?
CLA [x]